search

jadonk / bonescript

Scripting tools for BeagleBone and PocketBeagle
http://beagleboard.org
MIT License
514 stars 159 forks source link

add rcServo,rcIMU,rcBMP functions #178

Closed vaishnavachath closed 6 years ago

vaishnavachath commented 6 years ago

changes made to node-roboticscape: https://github.com/jadonk/node-roboticscape/pull/5

tested on: BeagleBone Blue BeagleBoard.org Debian Image 2018-03-05 Linux beaglebone 4.9.105-ti-r113 rc_version : 0.4.4

vaishnavachath commented 6 years ago

@jadonk i have updated the version in package.json ,"roboticscape" is already listed as an optional dependency, so if there is any use of obsolete functions(such as when the installed version of the library is old), shouldn't the optional dependency build fail without affecting other things, also the optional require is used inside rc.js : https://github.com/jadonk/bonescript/blob/0c7c11f0fd4041cee5296c4c11f7351f192e2ae7/src/rc.js#L3 , so would these not be necessary to deal with the fail cases you discussed,please let me know if i missed anything