jadonk / bonescript

Scripting tools for BeagleBone and PocketBeagle
http://beagleboard.org
MIT License
514 stars 158 forks source link

Fix beagleboard#53 and beagleboard#52 #180

Closed vaishnavachath closed 5 years ago

vaishnavachath commented 6 years ago

Fixed https://github.com/beagleboard/bonescript/issues/53 : analogWrite() slow when writing zero duty cycle , this was due to the test condition for async.until() method being misplaced , so the stopPWM() method was invoked continously, fixing the misplaced test condition fixes the issue.

Fixed https://github.com/beagleboard/bonescript/issues/52 : this relates to analogWrite() on digitalOUT being triggered when calling digitalWrite() , this occurs due to mux mode not being fetched, so added an additional check for it.

Both the issues/fixes were tested and found to be fixed on :

debian@beaglebone:~/bonescript$ uname -a
Linux beaglebone 4.9.82-ti-r102 #1 SMP PREEMPT Thu Feb 22 01:16:12 UTC 2018 armv7l GNU/Linux
debian@beaglebone:~/bonescript$ cat /etc/dogtag
BeagleBoard.org Debian Image 2018-03-05
Aidan275 commented 6 years ago

Hi guys,

When do you think the next version of bonescript will be released?

It would be great if these fixes could be included.

Thanks for all your efforts with this library.

Cheers, Aidan

jadonk commented 6 years ago

Aidan, it is out as version 0.7.0.

Aidan275 commented 6 years ago

When I install bonescript 0.7.0 in a new project these fixes aren't applied

screenshot from 2018-10-03 20-31-50

As you can see in the screenshot above, the lines 349 & 350 in hw_mainline.js are still around the wrong way.

Am I missing something?

Thanks

ludook commented 5 years ago

hello @jadonk @vaishnav98 , why this PR is still opened ? you don't want to integrate these fixes in a release ?

thx

kj800x commented 5 years ago

Any news on this PR? I'm having issues with analogWrite and I think this may be related.

/cc @jadonk

jadonk commented 5 years ago

Sorry for the delay. Missed these despite continuing to work with @vaishnav98. Creating 0.7.2.