Closed vaishnavachath closed 5 years ago
Hi guys,
When do you think the next version of bonescript will be released?
It would be great if these fixes could be included.
Thanks for all your efforts with this library.
Cheers, Aidan
Aidan, it is out as version 0.7.0.
When I install bonescript 0.7.0 in a new project these fixes aren't applied
As you can see in the screenshot above, the lines 349 & 350 in hw_mainline.js are still around the wrong way.
Am I missing something?
Thanks
hello @jadonk @vaishnav98 , why this PR is still opened ? you don't want to integrate these fixes in a release ?
thx
Any news on this PR? I'm having issues with analogWrite
and I think this may be related.
/cc @jadonk
Sorry for the delay. Missed these despite continuing to work with @vaishnav98. Creating 0.7.2.
Fixed https://github.com/beagleboard/bonescript/issues/53 : analogWrite() slow when writing zero duty cycle , this was due to the test condition for async.until() method being misplaced , so the stopPWM() method was invoked continously, fixing the misplaced test condition fixes the issue.
Fixed https://github.com/beagleboard/bonescript/issues/52 : this relates to analogWrite() on digitalOUT being triggered when calling digitalWrite() , this occurs due to mux mode not being fetched, so added an additional check for it.
Both the issues/fixes were tested and found to be fixed on :