search

jadonmmiller / UltimateDuetMenuSystem

An attempt to make the best set of menu files for a 12864 display run by a Duet Maestro.
The Unlicense
21 stars 9 forks source link

Fix preheat issues #3

Closed jaysuk closed 3 years ago

jaysuk commented 3 years ago

makes the changes recommended by dc42, rather than relying on a firmware fix

jadonmmiller commented 3 years ago

Good morning, and thanks a lot for your contribution! I've been meaning to fix the code, but haven't had the time. And yes, we shouldn't rely on a firmware fix to cover bad code! 😄

Unfortunately, David's code suggestion causes some layout issues on the bottom of the screen.

This snippet fixes the crashing issue and still looks good. If you replace the temperature section with this, I'd be glad to merge your PR.

Basically, it moves the horizontal line and nozzle icon up a pixel, but still keeps the right and left formatting of the temperature numbers, which caused issues on DC42's code.

; --------------- Temperatures ---------------
image R52 C0 L"imgs/hline.img"

; Bed Temperature
image R53 C5 L"imgs/bed.img"
value H2 N180
text T"/"
value N80

; Hotend Temperature
image R53 L"imgs/temp.img"
value H2 N100
text T"/"
value N0

Thanks! Jadon

jaysuk commented 3 years ago

Just updated it as requested

jadonmmiller commented 3 years ago

Thanks a lot! I've just merged it and will file a new release soon.