Fix issues with column resizing.

jadrake75 / ng-scrolling-table

MIT License

8 stars 2 forks source link

Fix issues with column resizing. #91

Closed Xanir closed 9 years ago

Xanir commented 9 years ago

Fixes performance issues when quickly dragging a columns over other columns.
Move all attributes from TABLE to wrapping DIV

jadrake75 commented 9 years ago

Maybe I am missing something, but when I pulled this pull request to test it only allows move of columns. I am also thinking the column "icon" for draggable columns should be a hand. ie. resize when it is on the edges and hand in the middle. We need to be careful about sort though....

Xanir commented 9 years ago

This fix addresses a performance issue I saw with dragging. When the dragged column was quickly moved over many columns the drop indicator would lag behind and take a while to catch up.

jadrake75 commented 9 years ago

Ok, I just did a pull request and merged a change that absorbed some of the changes here (except the resize changes). I think we need to rework this from master.

Xanir commented 9 years ago

Ignore my last comment, I was talking about column reordering. If you still have the submission handly can you check that the TDs are relatively positioned and there is a div absolutely position to the right of the TD.

Xanir commented 9 years ago

Commiting new version opposed to trying to fast-forward this commit.