Fix issues with column resizing.

jadrake75 / ng-scrolling-table

MIT License

8 stars 2 forks source link

Fix issues with column resizing. #97

Closed Xanir closed 9 years ago

Xanir commented 9 years ago

Ensure cursor icon is reset.
Allow continued column resizing even when cursor is outside of the THEAD.
Fix from last submission: Allow first column to be resizable.

Xanir commented 9 years ago

When testing this update your bower dependencies

jadrake75 commented 9 years ago

I am getting an undefined in here:

this.registerMouseDragHandler = function(mdElem, startMoveFunction, moveFunction, endMoveFunction, delay) {

within Services.min.js

the mdElem was just a DOM element so "on" was not valid. If I did a $(mdElem).on it worked.

So either the nz-services needs to be better protective or the caller of this needs to wrap/parse the element better. (I did a "grunt clean & bower install & grunt dev")

jadrake75 commented 9 years ago

I have checked in an update on the branch with proposed fixes

Xanir commented 9 years ago

Hmm, in the latest version v0.1.8 of nzServices the .on function is not used. See here: https://github.com/EnzeyNet/Services/blob/master/src/nzEventHelper.js#L121

It also throws an error if anything other then a DOM Node is passed in as the element.

jadrake75 commented 9 years ago

Issue was related to bower NOT updating the Services files from 0.1.7. Done and change reverted.