search

jaduff / LabLog

Software for recording physical users of computers in a lab environment.
MIT License
0 stars 1 forks source link

Why is ComputerId an int, instead of a guid? #27

Closed jaduff closed 6 years ago

jaduff commented 6 years ago

A computer is unique. It exists only in one place at a time. It may be moved from one room to another, but if it exists in two rooms, it is in error. Given the structure of the domain with room as aggregate, could/should computerid be a guid?

simonjduff commented 6 years ago

Because you said they have numbers, no other reason

jaduff commented 6 years ago

either guid, or serial number would be more useful as unique identifier. If a machine were to be moved, it is the machine that the damage and usage history sticks with, not the position number. I probably said I wouldn't move computers, but I know other schools do routinely.

simonjduff commented 6 years ago

Change it :)

On Thu, 12 Oct 2017, 09:49 James Duff, notifications@github.com wrote:

either guid, or serial number would be more useful as unique identifier. If a machine were to be moved, it is the machine that the damage and usage history sticks with, not the position number. I probably said I wouldn't move computers, but I know other schools do routinely.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jaduff/LabLog/issues/27#issuecomment-336063846, or mute the thread https://github.com/notifications/unsubscribe-auth/ALHMqBPDBc9DU5TL1dyfQfd5qs9lVoN6ks5srdKqgaJpZM4P2qYU .