search

jaduff / LabLog

Software for recording physical users of computers in a lab environment.
MIT License
0 stars 1 forks source link

No name in Room class for LabLog.domain #6

Closed jaduff closed 6 years ago

jaduff commented 6 years ago

Need to add the ability to give a name to the room before the event is saved.

jaduff commented 6 years ago

Testing incomplete. Can't test for the Room Name in the event, as it is stored in the Event Body rather than the event itself. How do you test for it? Have partially implemented but commented out.

simonjduff commented 6 years ago

Assert against the event body. You'll need to cast ILabEvent back to LabEvent first. Or you could deserialize EventBody and then assert

On Sat, 23 Sep 2017, 12:20 James Duff notifications@github.com wrote:

Assigned #6 https://github.com/jaduff/LabLog/issues/6 to @simonjduff https://github.com/simonjduff.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/jaduff/LabLog/issues/6#event-1262298730, or mute the thread https://github.com/notifications/unsubscribe-auth/ALHMqChCVlizG0-iPJOshs8K6pg_11rxks5slOmCgaJpZM4PhfNb .

jaduff commented 6 years ago

How do I cast ILabEvent back to LabEvent? And then what do I do with it?

jaduff commented 6 years ago

PR merged, issue closed.