Closed andy-lang closed 1 year ago
@jaedb this PR will solve https://github.com/jaedb/Iris/actions/runs/6506105033/job/17671008009
Could we add CI that runs shellcheck to make sure mistakes like this don't happen?
Could we add CI that runs shellcheck to make sure mistakes like this don't happen?
These tests already failed; https://github.com/jaedb/Iris/commit/e152f2ae6fd5ac9a87bc8ccbed49ea73f1f47aa9. I think failed tests where ignored before tagging 3.69.0. @jaedb any update on this?
Nice spotting, and yep this is handled by CI. The issue at hand here is that the creation of a release in GitHub is the triggerpoint for the release on PyPi and DockerHub. Always room for improvement, but nice that the CI prevented a broken release from being distributed.
Adds an
fi
to an if statement block - was causing issues with running commands insystem.sh
(e.g.local_scan
), both via web UI and terminal.