Invalid SPDX License

[jfhbrook]

Iris version

3.69.3

Operating system(s) affected

• [ ] Windows
• [ ] MacOS
• [ ] iOS
• [ ] Android
• [X] Linux
• [ ] Other

Browser(s) affected

• [ ] Firefox
• [ ] Chrome
• [ ] Edge
• [ ] Other

What happened?

I'm trying to build this package for Fedora using a tool called pyp2spec. It has behavior where it will error out if the license isn't a valid SPDX license. Sure enough, I run into that error:

Fatal exception occurred: Invalid SPDX expression: Apache License, Version 2.0

The fix appears to be changing the setup.cfg file to list the license as Apache-2.0 instead of Apache License, Version 2.0.

I know this is arguably an issue with pyp2spec and I do have alternate paths I can take. But this also seems like an easy and non-harmful fix on this side of things. Is this a change we can make?

Logs

Warning: Permanently added '54.163.63.223' (ED25519) to the list of known hosts.

You can reproduce this build on your computer by running:

  sudo dnf install copr-rpmbuild
  /usr/bin/copr-rpmbuild --verbose --drop-resultdir --srpm --task-url https://copr.fedorainfracloud.org/backend/get-srpm-build-task/7919275

Version: 0.73
PID: 7158
Logging PID: 7159
Task:
{'appstream': False,
 'background': False,
 'build_id': 7919275,
 'chroot': None,
 'package_name': 'python3-mopidy-iris',
 'project_dirname': 'stardeck',
 'project_name': 'stardeck',
 'project_owner': 'jfhbrook',
 'repos': [],
 'sandbox': 'jfhbrook/stardeck--jfhbrook',
 'source_json': {'pypi_package_name': 'Mopidy-Iris',
                 'pypi_package_version': '3.69.3',
                 'python_versions': ['3'],
                 'spec_generator': 'pyp2spec',
                 'spec_template': ''},
 'source_type': 5,
 'submitter': 'jfhbrook',
 'task_id': '7919275'}

Running: which pyp2spec

cmd: ['which', 'pyp2spec']
cwd: .
rc: 0
stdout: /usr/bin/pyp2spec
stderr: 

Running: pyp2spec Mopidy-Iris --fedora-compliant --top-level -v 3.69.3

cmd: ['pyp2spec', 'Mopidy-Iris', '--fedora-compliant', '--top-level', '-v', '3.69.3']
cwd: .
rc: 1
stdout: Generating configuration file
Assuming 'Mopidy-Iris' is a package name
Querying PyPI for package 'Mopidy-Iris'
Assuming --description=This is package 'Mopidy-Iris' generated automatically by pyp2spec.
Assuming --summary=Fully-featured Mopidy frontend client
Fatal exception occurred: Invalid SPDX expression: Apache License, Version 2.0
stderr: 

Unable to generate spec for `Mopidy-Iris'
Copr build error:

[auroraanna]

pyp2spec should not require and SPDX license identifier since that's not mandated by the spec: https://setuptools.pypa.io/en/latest/references/keywords.html

[jfhbrook]

Honestly, I don't disagree