jaegertracing / docker-protobuf

An all-inclusive protoc Docker image for the Jaeger project
https://hub.docker.com/r/jaegertracing/protobuf
Apache License 2.0
93 stars 35 forks source link

Missing protoc-gen-go-grpc #23

Open nicodmf opened 3 years ago

nicodmf commented 3 years ago

Summary

Always works fine with other language but go demand protoc-gen-go-grpc to generate proper files

docker run --rm -u ${UID} -v${PWD}:${PWD} -w${PWD} jaegertracing/protobuf:latest --go_out=grpc/go/grpc --proto_path=${PWD} --go-grpc_out=. --go-grpc_opt=paths=source_relative helloworld.proto
protoc-gen-go-grpc: program not found or is not executable
--go-grpc_out: protoc-gen-go-grpc: Plugin failed with status code 1.

Steps to Reproduce

  1. download https://raw.githubusercontent.com/grpc/grpc-go/master/examples/helloworld/helloworld/helloworld.proto
  2. launch command docker run --rm -u ${UID} -v${PWD}:${PWD} -w${PWD} jaegertracing/protobuf:latest --go_out=grpc/go/grpc --proto_path=${PWD} --go-grpc_out=. --go-grpc_opt=paths=source_relative helloworld.proto

What do you see now?

protoc-gen-go-grpc: program not found or is not executable
--go-grpc_out: protoc-gen-go-grpc: Plugin failed with status code 1.

What do you want to see instead?

command end without error

Environment

Linux

...

How do you propose to implement this?

not shure

Can you do this yourself and submit a Pull Request?

not without propositions

yurishkuro commented 3 years ago

I think because it is primarily designed to work with gogoproto, not the default go-grpc plugin.

See https://github.com/jaegertracing/jaeger/blob/master/Makefile#L500