Closed h4shk4t closed 5 months ago
Name | Link |
---|---|
Latest commit | 64e4bd4e1fac5d0f21b273ce6607488ad68dfc33 |
Latest deploy log | https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/660f1d001d0b7d0008674460 |
Deploy Preview | https://deploy-preview-668--romantic-neumann-1959d7.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The spellchecker flags normal words, so I don't see it as a viable solution at this point. Maybe it needs better dictionaries. Also, I would argue it should not be checking test formatted as code, because that will always bring a lot of noise.
@yurishkuro I did some digging and found the latest dictionary by aspell
from 2020 in one of their mirrors. It shows some improvement where it is not flagging words like mentorship
, analytics
and more (verified this manually). However there are still a lot more common words which are still being flagged like roadmap
and onboarding
. I was trying Hunspell again, but I am facing issues with making it ignore hexadecimal values (will try to look for some bypasses to fix this issue in the meantime). Kindly advise if I should continue with aspell
with a custom dictionary which also includes words like roadmap and onboarding, or to try and make Hunspell
reduce false positives from code blocks and hexadecimal values.
@h4shk4t I don't have preference in the tool, I only have preference for the end result - low friction :-)
@yurishkuro Made the changes. Using cspell
binary for spellchecking. Gives a promising accuracy and far lesser tolerance for false positives. Kindly let me know if this suffices.
Best Regards
The lint step is catching some real misspellings now, plus a few words that need to go to the dictionary
The lint step is catching some real misspellings now, plus a few words that need to go to the dictionary
Yes, I will add the new words to the dictionary (must have missed them earlier). What should I do about the misspellings?
Which problem is this PR solving?
Description of the changes