search

jaegertracing / documentation

Documentation/website for the Jaeger Distributed Tracing project.
https://jaegertracing.io/
Apache License 2.0
65 stars 158 forks source link

Upgrade Hugo 0.123.6 & fix related warning and error #675

Closed tico88612 closed 6 months ago

tico88612 commented 6 months ago

Which problem is this PR solving?

Description of the changes

FYI

How was this change tested?

Checklist

netlify[bot] commented 6 months ago

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
Latest commit d8287757d89618afbd1f3830fbc8cfcd614989b9
Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/65e66d85bbe8080008c76d31
Deploy Preview https://deploy-preview-675--romantic-neumann-1959d7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tico88612 commented 6 months ago

UPD: 0.120.3 will get the warning message 0.123.6 not.

https://github.com/jaegertracing/documentation/blob/08b96a308be252c3eac4f592f732e512e59e4dbb/themes/jaeger-docs/layouts/partials/docs/header.html#L13 https://github.com/jaegertracing/documentation/blob/08b96a308be252c3eac4f592f732e512e59e4dbb/themes/jaeger-docs/layouts/partials/meta.html#L20

I would fix it.

tico88612 commented 6 months ago

@yurishkuro If there is no such file themes/jaeger-docs/layouts/_default/section.html, a warning message will pop up.

WARN  found no layout file for "html" for kind "section": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.

FYI:

yurishkuro commented 6 months ago

I am seeing these additional warnings (which are for some reason tagged as INFO, even though they should break in the future):

INFO  deprecated: .Site.IsServer was deprecated in Hugo v0.120.0 and will be removed in a future release. Use hugo.IsServer instead.
INFO  deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and will be removed in a future release. use resources.Get or resources.GetRemote with transform.Unmarshal.
tico88612 commented 6 months ago

I am seeing these additional warnings (which are for some reason tagged as INFO, even though they should break in the future):

INFO  deprecated: .Site.IsServer was deprecated in Hugo v0.120.0 and will be removed in a future release. Use hugo.IsServer instead.
INFO  deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and will be removed in a future release. use resources.Get or resources.GetRemote with transform.Unmarshal.

Fixed.

yurishkuro commented 6 months ago

Thanks!