search

jaegertracing / documentation

Documentation/website for the Jaeger Distributed Tracing project.
https://jaegertracing.io/
Apache License 2.0
65 stars 158 forks source link

Fix: Navbar hover background color much darker #690

Closed tico88612 closed 5 months ago

tico88612 commented 5 months ago

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

netlify[bot] commented 5 months ago

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
Latest commit 5ce839625640a75f93c6731a128da0804c0a4edd
Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/660e14147a890800081e2821
Deploy Preview https://deploy-preview-690--romantic-neumann-1959d7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yurishkuro commented 5 months ago

Do you think we can also add this highlighting to the left and right sidebar menus?

image
tico88612 commented 5 months ago

Do you mean like this? (only left and right sidebar, not included content)

https://github.com/jaegertracing/documentation/assets/17496418/a127787e-b536-4a1c-ab1f-98a3f371b575

yurishkuro commented 5 months ago

Not quite - this changes all links, I was only thinking of the menus and the highlights would be row level, not text-only, similar to how it's in the top nav bar

tico88612 commented 5 months ago

Disclaimer: I'm not a UI/UX designer; I'm just examining it from my own aesthetic point of view.

The right-side menu is OK. Does the left menu look like this movie if it is changed to look like the navigation bar above? (from bulma.io)

https://github.com/jaegertracing/documentation/assets/17496418/27a2375b-388d-4093-a166-49b0b490bb7c

But we can open a new issue to discuss this.

yurishkuro commented 5 months ago

you're right, the right side menu is already using row highlighting, only the left one doesn't. The 2nd video looks great as an example (it even does indentation of the highlight on children menu items)