jaegertracing / documentation

Documentation/website for the Jaeger Distributed Tracing project.
https://jaegertracing.io/
Apache License 2.0
65 stars 158 forks source link

[WIP]: Fix for RSS feed is crashing the build #711

Closed chamodshehanka closed 2 months ago

chamodshehanka commented 2 months ago

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

netlify[bot] commented 2 months ago

Deploy Preview for romantic-neumann-1959d7 failed.

Name Link
Latest commit 123417782d1553aa361de31899cb6496ad6134cd
Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/666c1e7b8ebe270008683689
yurishkuro commented 2 months ago

You can test changes locally with make develop.

To make the testing cycles faster I found it useful to delete most of content/docs/1.xx directories, e.g. leave only 1.58 (but obviously don't commit this way), so that hugo has much fewer pages to process.

yurishkuro commented 2 months ago

And please make sure all commits are signed.

chamodshehanka commented 2 months ago

You can test changes locally with make develop.

To make the testing cycles faster I found it useful to delete most of content/docs/1.xx directories, e.g. leave only 1.58 (but obviously don't commit this way), so that hugo has much fewer pages to process.

sure! I'll

yurishkuro commented 2 months ago

@chamodshehanka I couldn't push a fix to this PR because you did it from the main branch of your fork - I strongly advise against doing that in the future, always use dedicated branch.

The fix is in https://github.com/jaegertracing/documentation/pull/713

chamodshehanka commented 2 months ago

@chamodshehanka I couldn't push a fix to this PR because you did it from the main branch of your fork - I strongly advise against doing that in the future, always use dedicated branch.

The fix is in #713

my apologize for that. I won't do that in the future. Thanks