jaegertracing / documentation

Documentation/website for the Jaeger Distributed Tracing project.
https://jaegertracing.io/
Apache License 2.0
68 stars 164 forks source link

Made toc Sidebar Expand to Fit Page, per issue #744 by yurishkuro #748

Open Donovan-Porter opened 1 month ago

Donovan-Porter commented 1 month ago

As per issue #744, opened by yurishkuro, I made the sidebar expand to fill the page.

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Screenshot 2024-09-26 161400 Screenshot 2024-09-26 161415

netlify[bot] commented 1 month ago

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
Latest commit eebba2b9efc63cb788b20dccff1dc1eade107244
Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/66f5c70bcc04560008adc554
Deploy Preview https://deploy-preview-748--romantic-neumann-1959d7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yurishkuro commented 1 month ago

I see it now expands to more than the height of the page.

Donovan-Porter commented 1 month ago

Yes, I figured it doesn't much matter because of the ample whitespace, but the height could be finetuned. I used 6rem because that's the value of the "$navbar-height" in the "variables.sass" file, but the sidebar's top is below 6rem from the top of the window. I also couldn't seem to get the $navbar-height variable to read properly in the calc() function.

Another issue that I didn't catch before submitting the pull request is the doubled scroll bar.