Open Donovan-Porter opened 1 month ago
Name | Link |
---|---|
Latest commit | eebba2b9efc63cb788b20dccff1dc1eade107244 |
Latest deploy log | https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/66f5c70bcc04560008adc554 |
Deploy Preview | https://deploy-preview-748--romantic-neumann-1959d7.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I see it now expands to more than the height of the page.
Yes, I figured it doesn't much matter because of the ample whitespace, but the height could be finetuned. I used 6rem because that's the value of the "$navbar-height" in the "variables.sass" file, but the sidebar's top is below 6rem from the top of the window. I also couldn't seem to get the $navbar-height variable to read properly in the calc() function.
Another issue that I didn't catch before submitting the pull request is the doubled scroll bar.
As per issue #744, opened by yurishkuro, I made the sidebar expand to fill the page.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test