search

jaegertracing / documentation

Documentation/website for the Jaeger Distributed Tracing project.
https://jaegertracing.io/
Apache License 2.0
68 stars 164 forks source link

Fixed typo in scripts/cspell/project-words.txt #753

Closed priyanshsao closed 1 month ago

priyanshsao commented 1 month ago

Which problem is this PR solving?

Description of the changes

Checklist

netlify[bot] commented 1 month ago

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
Latest commit b209af25f421222ed45f6e1b97999da7b188b339
Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/67095bad3553a2000833cf18
Deploy Preview https://deploy-preview-753--romantic-neumann-1959d7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yurishkuro commented 1 month ago

It is failing now

priyanshsao commented 1 month ago

So, should I consider reverting the change?

yurishkuro commented 1 month ago

You need to make sure the linter passes. You can test it locally.

priyanshsao commented 1 month ago

The reason ingester's appears before ingesters in a sorted list is that it is treated as "ingester" followed by an apostrophe, whereas ingesters is treated as "ingester" followed by the letter s. This means that the apostrophe has a higher priority in the sort order than the letter s. If you were to place ingester's after ingesters, it would trigger a sorting error because the list is expected to follow alphabetical order, taking into account all characters, including punctuation. This is why it fails to pass the linter.

yurishkuro commented 1 month ago

I don't understand the motivation for your explanation - what are you trying to prove? Before your change the linter was not complaining, now it does complain.

priyanshsao commented 1 month ago

To check i ran the 'make checkspell' in main branch and it showed the same error , i understand what you are saying but in main branch where nothing is changed still it is showing the error.

priyanshsao commented 1 month ago

@yurishkuro, I apologize for the confusion earlier. There was an issue with my terminal, which caused the error to appear.