search

jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
269 stars 347 forks source link

Support batch/v1 for CronJob resources #356

Closed bstoutenburgh closed 2 years ago

bstoutenburgh commented 2 years ago

Requirement - what kind of business use case are you trying to solve?

The batch/v1beta1 API will no longer be served by the API starting in the 1.25 release of Kubernetes, supporting batch/v1 avoids when that is available to users.

Problem - what in Jaeger blocks you from solving the requirement?

The batch/v1beta1 API will no longer be served by the API starting in the 1.25 release of Kubernetes, supporting batch/v1 avoids when that is available to users.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Probably use common.capabilities.cronjob.apiVersion from the Bitnami Common Library Chart similar to how Ingress resources utilize it.

https://kubernetes.io/docs/reference/using-api/deprecation-guide/#cronjob-v125 indicates there are no notable changes so probably sufficient to replace the apiVersion lines with something like apiVersion: {{- include common.capabilities.cronjob.apiVersion $ }}. (or whatever the exact syntax is)

Any open questions to address

mehta-ankit commented 2 years ago

yup as you said apiVersion: {{ include "common.capabilities.cronjob.apiVersion" $ }} as used here for Query Ingress

Defined here in Bitnami common chart. Would you like to make a PR for this change @maristgeek ?? 😃

bstoutenburgh commented 2 years ago

Don't let me hold it up, it will be a while (days) before I will have the 5 minutes free and not feel like I should be doing something else.