[jaeger] Add gRPC port to query deployment and service

roee-landesman commented 2 years ago

What this PR does

This PR adds a gRPC port to the query deployment and query service such that other services (namely kiali in my case) can connect over a dedicated gRPC port.

The kiali docs recommend gRPC connection to the query as well: https://kiali.io/docs/faq/distributed-tracing/#why-is-jaeger-unreachable-or-kiali-showing-the-error-could-not-fetch-traces

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #302

Checklist

[x] DCO signed
[x] Commits are GPG signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[x] README.md has been updated to match version/contain new values

pavelnikolov commented 2 years ago

@roee-landesman the commit needs to be signed before merging. You have pushed two commits and only the second one is signed.

roee-landesman commented 2 years ago

Hm, looks like they're both signed no?

pavelnikolov commented 2 years ago

https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#default-statuses

roee-landesman commented 2 years ago

Apologies for the messy commit history here, this was my first time playing with GPG keys and Git. I think it should be all good to go now!

jaegertracing / helm-charts