jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
269 stars 347 forks source link

[jaeger] Add support for adding relabelings & metricRelabelings on serviceMonitors #365

Closed mehta-ankit closed 2 years ago

mehta-ankit commented 2 years ago

Requirement - what kind of business use case are you trying to solve?

Support for metricRelabelings and relabelings on serviceMonitors deployed from the chart. https://www.robustperception.io/relabel_configs-vs-metric_relabel_configs

Problem - what in Jaeger blocks you from solving the requirement?

In the current chart we cannot pass in metricRelabelings and relabelings as values. Only way is to disable chart specific serviceMonitors and add your own.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add support for these keys. By default they would be empty lists [], but can be overridden to pass in your own values to drop, keep metrics.

Any open questions to address