jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
269 stars 347 forks source link

[jaeger] Custom labels in query and collector ingresses #378

Closed NicolasLemince closed 2 years ago

NicolasLemince commented 2 years ago

Signed-off-by: Nicolas nicorabatel@gmail.com

What this PR does

Adding values to be able to add custom labels in query and collector ingresses

Which issue this PR fixes

Checklist

NicolasLemince commented 2 years ago

I had to re create a PR after mess up with my commits -_-

mehta-ankit commented 2 years ago

@NicolasLemince what do you think about adding a section to the values.yaml file as an example. Something like this: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/values.yaml#L352

NicolasLemince commented 2 years ago

@NicolasLemince what do you think about adding a section to the values.yaml file as an example. Something like this: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/values.yaml#L352

Done with the last commit.

mehta-ankit commented 2 years ago

@NicolasLemince what do you think about adding a section to the values.yaml file as an example. Something like this: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/values.yaml#L352

Done with the last commit.

Can you fix the trailing spaces error lint job is throwing

image
NicolasLemince commented 2 years ago

@NicolasLemince what do you think about adding a section to the values.yaml file as an example. Something like this: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/values.yaml#L352

Done with the last commit.

Can you fix the trailing spaces error lint job is throwing image

Done with the last commit