[Feature]: TTL setting for esIndexCleaner jobs after completion

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

265 stars 340 forks source link

[Feature]: TTL setting for esIndexCleaner jobs after completion #393

Closed Mahagon closed 2 years ago

Mahagon commented 2 years ago

Requirement

As a Kubernetes Administrator I would like to set ttlSecondsAfterFinished for the es index cleaner so that old jobs in completed state get removed sooner

Problem

Old jobs in completet state remain for hours

Proposal

Like in esRollover i would like ttlSecondsAfterFinished entry for esIndexCleaner https://github.com/jaegertracing/helm-charts/blob/eff00f612e3acf0cb335b169c6186ff581a40d2b/charts/jaeger/values.yaml#L692

Open questions

No response

mehta-ankit commented 2 years ago

I know esRolllover is a job and i am guessing jobTemplate.spec should be able to take this ttlSecondsAfterFinished flag which is available on a job Sounds like a good addition.

@Mahagon would you like to make a PR with this change ? Happy to take the contribution.