jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
265 stars 340 forks source link

[jaeger] Add ttlSecondsAfterFinished entry to esIndexCleaner job #396

Closed Mahagon closed 2 years ago

Mahagon commented 2 years ago

Add ttlSecondsAfterFinished entry to esIndexCleaner for removing completed jobs of the ElasticSearch Index Cleaner after the configured amount of time

What this PR does

Make ttlSecondsAfterFinished for esIndexCleaner configurable

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Checklist

mehta-ankit commented 2 years ago

@Mahagon You also need to update the chart version.

mehta-ankit commented 2 years ago

@Mahagon thanks for all the changes. 🙏🏽 Are you comfortable squashing all your commits into 1 or 2 commits ? That would be great. Also I don't think the commits are GPG signed. Can you do that too plz.

Mahagon commented 2 years ago

Sure :) squashed the commits and added my gpg signature

mehta-ankit commented 2 years ago

@Mahagon i merged another PR recently, so you'd have to bump the chart version.