search

jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
265 stars 340 forks source link

[jaeger] exposing 16685 for helm and allinone deploy #409

Closed palmheads closed 1 year ago

palmheads commented 1 year ago

What this PR does

When using the all-in-one jaeger deploy with helm, opens up port 16685 which currently gets a connection refused

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Checklist

mehta-ankit commented 1 year ago

@palmheads can you squash your commits into one if possible ? That way you only need to gpg sign 1 commit

palmheads commented 1 year ago

Hi @mehta-ankit - haven't done a squash before - was that what you are looking for?

mehta-ankit commented 1 year ago

Hi @mehta-ankit - haven't done a squash before - was that what you are looking for?

Squash/fixup would combine the commits into 1. https://www.internalpointers.com/post/squash-commits-into-one-git

mehta-ankit commented 1 year ago

@palmheads You would also need to rebase with main branch as another PR merged and you now have conflicts. Thanks

palmheads commented 1 year ago

Hi @mehta-ankit - accidently closed this PR - opened another with a clean fork & commit with chart bumped https://github.com/jaegertracing/helm-charts/pull/413