Closed Mouness closed 1 year ago
Hi @mehta-ankit, Sorry for the delay. I just pushed the change. Hope it's ok for you
Hi anybody to check this PR, please?
Hi anybody to check this PR, please?
looking into it
@Mouness can you maybe please squash commits into 1 commit and gpg sign the commit (currently you have 3 commits and 2 are not gpg signed). Thanks
Hi @mehta-ankit , thanks for the review. I've signed the commits and squashed all my change.
Sorry for the back and forth I had to setup gpg locally
Sorry for the back and forth I had to setup GPG locally
no problem. Thanks a lot for squashing them 😄 (i appreciate it)
What this PR does
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Checklist
[jaeger]
or[jaeger-operator]
)