jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
265 stars 340 forks source link

[jaeger] fixes #329 missing prefix on esCronJobs #414

Closed Mouness closed 1 year ago

Mouness commented 1 year ago

What this PR does

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Checklist

Mouness commented 1 year ago

Hi @mehta-ankit, Sorry for the delay. I just pushed the change. Hope it's ok for you

Mouness commented 1 year ago

Hi anybody to check this PR, please?

mehta-ankit commented 1 year ago

Hi anybody to check this PR, please?

looking into it

mehta-ankit commented 1 year ago

@Mouness can you maybe please squash commits into 1 commit and gpg sign the commit (currently you have 3 commits and 2 are not gpg signed). Thanks

Mouness commented 1 year ago

Hi @mehta-ankit , thanks for the review. I've signed the commits and squashed all my change.

Mouness commented 1 year ago

Sorry for the back and forth I had to setup gpg locally

mehta-ankit commented 1 year ago

Sorry for the back and forth I had to setup GPG locally

no problem. Thanks a lot for squashing them 😄 (i appreciate it)