Closed steache closed 1 year ago
@steache just for my curiosity, what's the problem if path: / is not included 🤔. Also collector ingress has the same design: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/collector-ing.yaml#L28
@steache just for my curiosity, what's the problem if path: / is not included 🤔. Also collector ingress has the same design: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/collector-ing.yaml#L28
@mehta-ankit
edit: oh I see! I'll add default value for the collector as well
@steache just for my curiosity, what's the problem if path: / is not included 🤔. Also collector ingress has the same design: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/collector-ing.yaml#L28
@mehta-ankit
- good question, sorry for not mentioning it in the first place
- we are using bitnami/nginx-ingress-controller@9.3.23 and it's failing to pick up jaeger's ingress due to "misconfigured" path
- after changing it to path: / it started to work :)
- I have to admit, that I'm not sure if it's something that changed in jaeger or maybe in new release of nginx
edit: oh I see! I'll add default value for the collector as well
Thanks @steache . Also i see the base path is used to create an env var for query and collector deployments: https://github.com/jaegertracing/helm-charts/pull/420#issuecomment-1342831266
Wanted to share to make sure its not messing up anything 😄 . Thanks for the change though!
@steache can you please GPG sign your commit.
@steache can you please GPG sign your commit.
@mehta-ankit signed, sorry! :)
@steache can you fix the linting issue on the PR and maybe please squash your commits. These individual commits and their changes are not making much sense tbh.
sorry for trying again in https://github.com/jaegertracing/helm-charts/pull/422, I was not able to rearrange it properly
What this PR does
path: /
, I'm not sure if it's problem only fornginx-ingress-controller
or for more controllersChecklist
[jaeger]
or[jaeger-operator]
)