[jaeger] fix (query,collector) basePath - Githubissues

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

265 stars 340 forks source link

[jaeger] fix (query,collector) basePath #422

Closed steache closed 1 year ago

steache commented 1 year ago

What this PR does

fixes query.ingress for nginx-ingress-controller (probably more ingress controllers)
used in here https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/query-ing.yaml#L4 and here https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/query-ing.yaml#L28 but not defined :)
if it's not defined, chart will produce paths like this:

- pathType: ImplementationSpecific
  backend:
    service:
      name: jaeger-query
      port:
        number: 80

missing the path: /, I'm not sure if it's problem only for nginx-ingress-controller or for more controllers

Checklist

[x] DCO signed
[x] Commits are GPG signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[x] README.md has been updated to match version/contain new values