This was added last month as it seems. as the commandline arguments seem to be different i suggest removing {{- include "storage.cmdArgs" . | nindent 14 }}
Steps to reproduce
Add es.num-shards: "1" to storage.elasticsearch.cmdlineParams
Add esIndexCleaner
Expected behavior
Jaeger chart should not deploy commmandline arguments of the storage to the index cleaner commandline arguments as they are different
Relevant log output
jaeger-es-index-cleaner-27857650-rgh24 Error: unknown flag: --es.num-replicas
jaeger-es-index-cleaner-27857650-rgh24 Usage:
jaeger-es-index-cleaner-27857650-rgh24 jaeger-es-index-cleaner NUM_OF_DAYS http://HOSTNAME:PORT [flags]
jaeger-es-index-cleaner-27857650-rgh24
jaeger-es-index-cleaner-27857650-rgh24 Flags:
jaeger-es-index-cleaner-27857650-rgh24 --archive Whether to remove archive indices. It works only for rollover
jaeger-es-index-cleaner-27857650-rgh24 --es.password string The password required by storage
jaeger-es-index-cleaner-27857650-rgh24 --es.tls.ca string Path to a TLS CA (Certification Authority) file used to verify the remote server(s) (by default will use the system truststore)
jaeger-es-index-cleaner-27857650-rgh24 --es.tls.cert string Path to a TLS Certificate file, used to identify this process to the remote server(s)
jaeger-es-index-cleaner-27857650-rgh24 --es.tls.enabled Enable TLS when talking to the remote server(s)
jaeger-es-index-cleaner-27857650-rgh24 --es.tls.key string Path to a TLS Private Key file, used to identify this process to the remote server(s)
jaeger-es-index-cleaner-27857650-rgh24 --es.tls.server-name string Override the TLS server name we expect in the certificate of the remote server(s)
jaeger-es-index-cleaner-27857650-rgh24 --es.tls.skip-host-verify (insecure) Skip server's certificate chain and host name verification
jaeger-es-index-cleaner-27857650-rgh24 --es.username string The username required by storage
jaeger-es-index-cleaner-27857650-rgh24 -h, --help help for jaeger-es-index-cleaner
jaeger-es-index-cleaner-27857650-rgh24 --index-date-separator string Index date separator (default "-")
jaeger-es-index-cleaner-27857650-rgh24 --index-prefix string Index prefix
jaeger-es-index-cleaner-27857650-rgh24 --rollover Whether to remove indices created by rollover
jaeger-es-index-cleaner-27857650-rgh24 --timeout int Number of seconds to wait for master node response (default 120)
jaeger-es-index-cleaner-27857650-rgh24
jaeger-es-index-cleaner-27857650-rgh24 2022/12/19 14:10:03 unknown flag: --es.num-replicas
Stream closed EOF for jaeger/jaeger-es-index-cleaner-27857650-rgh24 (jaeger-es-index-cleaner)
What happened?
The jaeger helm chart adds the storage cmdline parameters to the indexcleaner cmdline parameters
https://github.com/jaegertracing/helm-charts/blame/8e0dbeb3ab63861c55cb8f1da89a50158ae11c6c/charts/jaeger/templates/es-index-cleaner-cronjob.yaml#L57
This was added last month as it seems. as the commandline arguments seem to be different i suggest removing
{{- include "storage.cmdArgs" . | nindent 14 }}Steps to reproduce
es.num-shards: "1"to storage.elasticsearch.cmdlineParamsExpected behavior
Jaeger chart should not deploy commmandline arguments of the storage to the index cleaner commandline arguments as they are different
Relevant log output
Screenshot
No response
Additional context
No response
Jaeger backend version
No response
SDK
No response
Pipeline
No response
Stogage backend
Elasticsearch v7.17
Operating system
No response
Deployment model
No response
Deployment configs
No response