jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
265 stars 340 forks source link

[jaeger] Provide the ability to connect to Elasticsearch with TLS #426

Closed OpenGuidou closed 1 year ago

OpenGuidou commented 1 year ago

Signed-off-by: Guillaume DOUSSIN guillaume.doussin@amadeus.com

What this PR does

Provide the ability to connect to an elastic search cluster using TLS.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Checklist

pavelnikolov commented 1 year ago

@OpenGuidou you have unsigned commits

OpenGuidou commented 1 year ago

@OpenGuidou you have unsigned commits

Is it better now ? I can see it in the commit tab: image

OpenGuidou commented 1 year ago

@pavelnikolov Is it ok now ? Can we merge this change ?

pavelnikolov commented 1 year ago

I still can't merge it. Is your commit GPG signed?

OpenGuidou commented 1 year ago

@pavelnikolov it should be ok now, there was a small glitch on my side

pavelnikolov commented 1 year ago

Could you, please, resolve the conflicts and I'd be happy to merge this.

OpenGuidou commented 1 year ago

Done !

mehta-ankit commented 1 year ago

@OpenGuidou Can you please gpg sign the commit as well 🙏🏼