jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
265 stars 340 forks source link

[Bug]: storage cli arguments where they don't belong #427

Closed Mahagon closed 1 year ago

Mahagon commented 1 year ago

What happened?

Yesterday i created a pr #425 for the ticket #424 where a cronjob wasn't able to run because it included unknown command line arguments

https://github.com/jaegertracing/helm-charts/blame/f5bffea5475972adfb3aedf79df754c8553c1096/charts/jaeger/templates/es-rollover-cronjob.yaml#L71

it seems that the issue is a little bit bigger, as i noticed today that esrollover doesn't work either when you append the storage cmdargs (logs see down below)

Why would those tasks need those arguments? I would like to discuss the removal of include "storage.cmdArgs"completely

Steps to reproduce

Add es.num-shards: "1" to storage.elasticsearch.cmdlineParams Add esRollover

Expected behavior

elasticsearch rollover job works

Relevant log output

jaeger-es-rollover-init-dtxrz Error: unknown flag: --es.num-replicas

Screenshot

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response