jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
269 stars 347 forks source link

[jaeger] - allinone use tpl function for args #428

Closed puckpuck closed 1 year ago

puckpuck commented 1 year ago

Signed-off-by: Pierre Tessier pierre@pierretessier.com

What this PR does

Uses the Helm tpl function to allow for command line args to be templated. This is required when Jaeger is used as a chart dependency and some options can only be determined at helm templating time (ie: release name).

Which issue this PR fixes

This allows for the OpenTelemetry demo to leverage Jaeger for tracing with Prometheus-backed metrics store configured in the Jaeger AllInOne deploy as merged recently in the otel demo PR 655

The OpenTelemetry demo helm chart will have a section to configure the prometheus sever url that looks like this:

  allInOne:
    enabled: true
    args:
      - "--prometheus.server-url"
      - 'http://{{ include "otel-demo.name" . }}-prometheus-server:9090'
    extraEnv:
      - name: METRICS_STORAGE_TYPE
        value: prometheus

Passing in the {{ include "otel-demo.name" .}} portion for the command line argument is what this PR enables.

Checklist