jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
265 stars 340 forks source link

[jaeger-operator] Adding serviceExtraLable for service #430

Closed robinelastisys closed 1 year ago

robinelastisys commented 1 year ago

What this PR does

This PR adds a value called 'serviceExtraLabels' to make it possible to add a label to the service you may not want to have in the operator to for example create a 'serviceMonitor' for it.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Checklist

batazor commented 1 year ago

@robinelastisys We also need to bump the version of the chart and sign commits

robinelastisys commented 1 year ago

@robinelastisys We also need to bump the version of the chart and sign commits

@batazor @cpanato Do i need to do anything more than this?

robinelastisys commented 1 year ago

PING! We would be grateful if this could be merged soon enough!

batazor commented 1 year ago

@robinelastisys Please add GPG signed

robinelastisys commented 1 year ago

@robinelastisys Please add GPG signed

Okay, now it should be correct! :+1: