[jaeger] Remove storage.cmdArgs from es index rollover commandline args

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

265 stars 340 forks source link

[jaeger] Remove storage.cmdArgs from es index rollover commandline args #431

Closed Mahagon closed 1 year ago

Mahagon commented 1 year ago

What this PR does

Storage cmdline args like es.num-replicas don't work for es rollover, including them makes it impossible to deploy (crashloop unknown cmdline arguments).

Which issue this PR fixes

fixes #427

Checklist

[x] DCO signed
[x] Commits are GPG signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[x] README.md has been updated to match version/contain new values

Mahagon commented 1 year ago

oof didn't want to close this :D

removed the storage cmdargs in es-rollover-cronjob and es-lookback-cronjob