search

jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
265 stars 340 forks source link

[Feature]: allow to specify path for the allInOne Ingress #434

Open mjedwabn opened 1 year ago

mjedwabn commented 1 year ago

Requirement

As a devops I want to specify Ingress path for Jaeger so that enduser can access Jaeger using http://hostname/custom_jaeger_path. Currently Jaeger is exposed at http://hostname/.

Problem

Ingress definition has hardcoded path as /: https://github.com/jaegertracing/helm-charts/blob/6ab6ed3f4607c6cdf92f3bf8ebffd296f87ac63d/charts/jaeger/templates/allinone-ing.yaml#L23

W/A - provide custom Ingress definition, written from scratch.

Proposal

Add a way to override Ingress path by introducing proper Helm variable, just like in standalone jaeger-query ingress: https://github.com/jaegertracing/helm-charts/blob/6ab6ed3f4607c6cdf92f3bf8ebffd296f87ac63d/charts/jaeger/templates/query-ing.yaml#L28

Open questions

No response

ereed248 commented 7 months ago

I have the same usecase and would also like to access Jaeger using http://hostname/custom_jaeger_path. My current workaround is to change line 23 in helm-charts/charts/jaeger/templates/allinone-ing.yaml to:

path: {{ default "/" $.Values.allInOne.ingress.path }}

Could we add this update to the chart?