jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
267 stars 347 forks source link

[jaeger] Allow pre-release format in helm-chart requirements #450

Closed brainfair closed 1 year ago

brainfair commented 1 year ago

What this PR does

Some Kubernetes vendors use a pre-release format for versioning, AWS EKS example: v1.24.8-eks-ffeb93d Current requirements are strict only with a release version as result >= 1.21 don't tolerate with v1.24.8-eks-ffeb93d Allow pre-release format with appendix -0 in the requirements for the chart. more info about working with pre-release format

Checklist

brainfair commented 1 year ago

@lollipopman related to your last changes https://github.com/jaegertracing/helm-charts/commit/fbe40d3c7370208680d9f5f9dd8720d9a42cd7ed

lollipopman commented 1 year ago

@brainfair, makes sense, thanks!