jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
258 stars 340 forks source link

[jaeger] Add flag enabling the ability to disable the cassandra-schema Job #454

Closed steakfest closed 1 year ago

steakfest commented 1 year ago

By default, the behavior will be identical to what it was before. Enabled by default.

This flag though, when set to false will disable the creation of the cassandra-schema-job Job resource.

What this PR does

I have a use case where I don't want the helm chart to attempt to run the cassandra-schema-job at all. Schema creation is our cassandra db is handled another way. Also I think I'm having trouble with this job running cleanly against our ScyllaDB / cassandra environment. So in the interest of having cleaner k8s deployments, wanted to just have the option to be able to turn this off.

This PR adds a flag in values. storage.cassandra.schemaJobEnabled which defaults to true so that existing behavior doesn't change at all. If you change the value of storage.cassandra.schemaJobEnabled=false Then the FULLNAME-cassandra-schema Job will not be created.

Which issue this PR fixes

None

Checklist