jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
267 stars 347 forks source link

[Feature]: #469

Open willemm opened 1 year ago

willemm commented 1 year ago

Requirement

As a jaeger operator, I want to be able to override the name of the jaeger customresource in the jaeger-operator helm chart, so that I can upograde from using the CR I wrote myself to using the helm-chart generated CR, while keeping the name the same.

Problem

Currently, the name of the jaeger CR is defined as: {{ include "jaeger-operator.fullname" . }}-jaeger which makes it impossible to override

Proposal

Change the definiution at https://github.com/jaegertracing/helm-charts/blob/1b4143ded4fa1df997427ea43aaa00bfdbe02467/charts/jaeger-operator/templates/jaeger.yaml#L5 to something like {{.Values.jaeger.name | default (printf "%s-jaeger" (include "jaeger-operator.fullname" .)) }}

Open questions

No response