[jaeger-operator]: Fixed support for custom ports

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

258 stars 340 forks source link

[jaeger-operator]: Fixed support for custom ports #483

Closed stevehipwell closed 1 year ago

stevehipwell commented 1 year ago

What this PR does

This PR sets the --metrics-port & --webhook-bind-port so if these values are changed from the default the operator continues to work correctly.

Which issue this PR fixes

Fixes #473

Checklist

[x] DCO signed
[x] Commits are GPG signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[x] README.md has been updated to match version/contain new values

stevehipwell commented 1 year ago

@batazor do all commits actually need signing?

batazor commented 1 year ago

@stevehipwell It would be nice to sign. Also need approval from @cpanato

stevehipwell commented 1 year ago

@batazor I can git sign but I think that will require re-approval.

FYI given the poor tooling integrations around signing commits (VS Code has issues and the current GitHub PR rebase logic removes the signature) requiring them for a repo like this it could be considered hostile to contributions.

stevehipwell commented 1 year ago

@batazor I've signed the commit could you please re-review?

batazor commented 1 year ago

@stevehipwell Yep. Thanks.

P.S. About the commit signing policy - I don't know, it was there in the beginning, and many repositories also require it from contributors. Signing is enabled once and then works all the time, I don't think it's a difficult constraint.