jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
258 stars 340 forks source link

[Bug]: All-In-One option should include option to specify secrets to be mounted as volumes #484

Closed conradhanson closed 1 year ago

conradhanson commented 1 year ago

What happened?

As a user of the Jaeger Helm Chart, I need to be able to specify secrets to mount as volumes as part of the all-in-one deployment option, so that TLS certs and keys can be referenced by corresponding cmd flag arguments. This allows the all-in-one service's to run with TLS enabled.

Steps to reproduce

  1. Go to the Jaeger Helm Chart, inspect the values.yaml and look at the allInOne section. There should be no extraSecretMounts option.

Expected behavior

The extraSecretMounts option should be available in the allInOne section, and referenced in the all-in-one deployment to populate volume mounts and specify volumes.

After configuring TLS-related cmd flags for certs, keys, and ca-certs in the allinone.extraArgs, configuring the allinone.extraSecretMounts with the referenced files, and deploying those secrets, I expect the all-in-one deployment to successfully start, and the TLS configured services to be accessed with TLS.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

v0.71.4

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

Kubernetes with Jaeger Helm Chart

Deployment configs

No response