jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
254 stars 338 forks source link

[jaeger] Unset default collector OTLP ports #491

Closed sam-mcbr closed 11 months ago

sam-mcbr commented 11 months ago

What this PR does

This sets the default values of the collector.service.otlp.grpc and collector.service.otlp.http to {} and also fixes a bug with the deploy logic that would prevent overriding these values with null. At the very least, the deploy change is needed because the values cannot be overridden with null and helm does not allow overriding them with {} (see https://github.com/helm/helm/issues/5407).

Checklist