[jaeger] make replicas a Helm value instead of hardcoding it

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

254 stars 338 forks source link

[jaeger] make replicas a Helm value instead of hardcoding it #494

Closed lisenet closed 11 months ago

lisenet commented 11 months ago

What this PR does

Adds a Helm value for allInOne.replicas.

Which issue this PR fixes

fixes #493

Checklist

[ ] DCO signed
[ ] Commits are GPG signed
[ ] Chart Version bumped
[ ] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[ ] README.md has been updated to match version/contain new values

pavelnikolov commented 11 months ago

@lisenet it doesn't make sense to use the all-in-one Jaeger with more than one replica since the data is in-memory. Therefore, different replicas wouldn't share the data between them. Am I missing something?

pavelnikolov commented 11 months ago

@mehta-ankit does it make sense to have more than one replica of the all-in-one container? I think it doesn't make sense and this PR shouldn't have been merged.

mehta-ankit commented 11 months ago

@mehta-ankit does it make sense to have more than one replica of the all-in-one container? I think it doesn't make sense and this PR shouldn't have been merged.

you do bring up a good point and I thought about it, but since this was a backwards compatible change I went ahead and merged it.

lisenet commented 11 months ago

@pavelnikolov our use case is that we need to deploy it with zero replicas so that no deployment is running but the config is there, and we flip the switch when we run a performance test to gather Istio tracing information. It is currently not possible to do so using the current chart version.

pavelnikolov commented 10 months ago

fyi https://github.com/jaegertracing/helm-charts/pull/499