jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
267 stars 347 forks source link

[jaeger] Add resources to oAuthSidecar #505

Closed Stevenpc3 closed 1 year ago

Stevenpc3 commented 1 year ago

[jaeger] Add resources to oAuthSidecar to allow setting in case of quota requirements

What this PR does

It updates the charts/jaeger/templates/query-deploy.yaml to add the ability to set resources via a values.yaml.

Which issue this PR fixes

Could not deploy with Oauth2 proxy sidecar in an environment that enforces quotas without manual config modifications.

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Checklist

Stevenpc3 commented 1 year ago

Is there a way to hurry this along? Could a maintainer just make an MR and skip this Pull request?

This is in an active system and the only currently acceptable work around would be to fork the repo and make our own charts for this. Otherwise we have to manually adjust the cofigmap after deploy and that is not manageable for the devs and number of deploys.

mehta-ankit commented 1 year ago

@Stevenpc3 can you GPG sign your commit please.

Stevenpc3 commented 1 year ago

uh lol... I would like to GPG sign, but I don't know how. Which is why I sheepishly suggested a maintainer do an MR. I can give it an attempt though.

Stevenpc3 commented 1 year ago

Thank you for replying also. Going to walk through this https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#gpg-commit-signature-verification

Stevenpc3 commented 1 year ago

Ok it appears I have figured it out. Should all be signed and ready to go.

Stevenpc3 commented 1 year ago

Thank you