jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
254 stars 338 forks source link

[Feature]: Badger support for all-in-one jaeger helm chart #511

Closed petarili closed 3 months ago

petarili commented 8 months ago

Requirement

All-in-one deployment on this helm chart by default only supports storage type of "memory". We will have to change that to make storage type dynamic where someone can pass in a value of badger: https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/allinone-deploy.yaml#L43

Problem

When we provide parameters for Badger support, SPAN_STORAGE_TYPE value is still "memory" because it is hardcoded in allinone-deploy.yaml script. Is it possible to provide support for dynamic setup of Badger parameters so that default "memory" SPAN_STORAGE_TYPE can be overwritten with "Badger" parameter and provided settings in ExtraEnv section?

Proposal

Modify allinone-deploy.yaml script on line https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/allinone-deploy.yaml#L39 to check for storage configuration from the values.yaml file.

Also make on line https://github.com/jaegertracing/helm-charts/blob/main/charts/jaeger/templates/allinone-deploy.yaml#L108 provide support for dynamic creation of volumes and volumemount since for example badger directory needs to be in a volume to persist information. Thank you in advance for the feedback.

Open questions

No response