[jaeger] Allow Jaeger ServiceAccounts to have annotations specified

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

254 stars 338 forks source link

[jaeger] Allow Jaeger ServiceAccounts to have annotations specified #519

Closed nabeelpaytrix closed 6 months ago

nabeelpaytrix commented 8 months ago

What this PR does

Annotations for ServiceAccounts can now be specified with helm values

Which issue this PR fixes

fixes #518

Checklist

[ * ] DCO signed
[ * ] Commits are GPG signed
[ * ] Chart Version bumped
[ * ] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[ * ] README.md has been updated to match version/contain new values

MPritsch commented 6 months ago

Hello, not sure about your roadmap, but will this be merged soon? We work with Opensearch on AWS and use iam-roles-for-service-accounts (IRSA) which need an annotation on the serviceAccounts. Without them jaeger can't reach Opensearch. Currently my only workaround is to generate the manifests from helm locally and append the serviceAccount annotation at the all-in-one serviceAccount. Thanks for your work and best regards

EDIT we switched from helm to the jaeger operator. There it is possible