jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
267 stars 347 forks source link

[Bug]: jaeger-chart: does not exist .Values.storage.elasticsearch.tls in es-rollover-hook.yml #521

Closed obervinov closed 10 months ago

obervinov commented 10 months ago

What happened?

Description es-rollover-hook.yml template does not support the .Values.storage.elasticsearch.tls settings, as implemented for example in es-rollover-cronjob.yaml.

This creates a situation where rollover-hook-init cannot be used with a custom CA configured via parameters storage.elasticsearch.tls, as it will fall with an error of the missing certificate installed in ES_TLS_CA.

If you try to use parameter .Values.esRollover.extraSecretMounts, it causes a conflict with the environment variable ES_TLS_CA.

The only option left is not to use parameter .Values.storage.elasticsearch.tls, but to manually declare extraSecrets and extraEnvs for each chart microservice.

I would like to correct this situation with a small edit.

Steps to reproduce

  1. Set these values for the jaeger chart
    
    storage:
    type: elasticsearch
    elasticsearch:
    scheme: https
    host: es-node-1.example.com
    tls:
      enabled: true
      secretName: intermidiate-ca-certificate

esRollover: enabled: true extraEnv:

Expected behavior

The .Value.storage.elasticsearch.tls parameter automatically adds the mounting of the specified Secret to the executed es-rollover-hook.yml just as in the template es-rollover-cronjob.yaml

Relevant log output

Error: failed to load CA CertPool: failed to load CA /es-tls/ca-cert.pem: open /es-tls/ca-cert.pem: no such file or directory

Screenshot

Снимок экрана 2023-11-15 в 17 32 18 Снимок экрана 2023-11-15 в 17 36 27

Additional context

No response

Jaeger backend version

v1.43

SDK

No response

Pipeline

No response

Stogage backend

Elasticsearch

Operating system

Linux

Deployment model

Kubernetes

Deployment configs

No response