search

jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
254 stars 338 forks source link

Jaeger bump kafka common dependency #525

Closed dpericaxon closed 5 months ago

dpericaxon commented 7 months ago

What this PR does

This PR bumps the Kafka Dependency.

The Kafka helm chart has gone through a refactor: https://github.com/bitnami/charts/tree/main/bitnami/kafka#to-2400 and moved away from Zookeeper to Kraft: https://developer.confluent.io/learn/kraft/ . Zookeeper is disabled by default in the newer versions of the Kafka Helm chart.

This PR bumps the Kafka dependency, adds out of the box Kafka values to values.yaml and also includes documentation for the changes related to Kafka.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Checklist

pavelnikolov commented 7 months ago

Thank you @dpericaxon! Could you, please, ensure the PR checklist items are checked before proceeding?

dpericaxon commented 6 months ago

@pavelnikolov fixed. I made the chart version v1.0.0 since it is a breaking change with Kafka and also includes the latest Kafka helm chart which includes a later version of Zookeeper. With the breaking changes in the Kafka Helm chart, its not backwards compatible and Zookeeper is disabled by default. See more information here regarding the major refactor they did: https://github.com/bitnami/charts/tree/main/bitnami/kafka#to-2400

dpericaxon commented 6 months ago

@dvonthenen @naseemkullah it looks like Pavel might be on vacation. Do either of you mind taking a look at the comment above and changes when you get a chance please?

dpericaxon commented 5 months ago

@pavelnikolov @dvonthenen @naseemkullah can someone take a look please?

pavelnikolov commented 5 months ago

I can't currently test this locally with Kafka. Can someone else confirm that it works before merging?

gburton1 commented 5 months ago

It would be great to get this in; it's working well in our QA environment, but we are holding off on releasing widely until it's in an official release.