jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
254 stars 338 forks source link

[jaeger] Update Jaeger version in helm chart #544

Closed tronda closed 2 months ago

tronda commented 3 months ago

What this PR does

Update to the latest released Jaeger version.

Which issue this PR fixes

None

Checklist

tronda commented 3 months ago

Not sure why the Kafka related template fails for this change.

pavelnikolov commented 3 months ago

Maybe we can leave the Kafka sub-chart version untouched for now šŸ¤”

tronda commented 3 months ago

Maybe we can leave the Kafka sub-chart version untouched for now šŸ¤”

I've pinned the Kafka chart on the previous version with the latest commit.

bens545 commented 3 months ago

It's likely still failing due to the common chart update. Try reverting it to the previous version and testing.

alex1989hu commented 2 months ago

@tronda is there any particular reason (probably I overlooked it) why appVersion change is not enough here?

On the other hand, role.yaml must be also updated due to

tronda commented 2 months ago

@tronda is there any particular reason (probably I overlooked it) why appVersion change is not enough here?

I just wanted the latest version of Jaeger by default with the helm chart and my own preference to always update to the latest dependencies.

On the other hand, role.yaml must be also updated due to

Probably somebody else should do the update since I don't know the details here.