search

jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
267 stars 347 forks source link

[Bug]: Indents for imagePullSecrets in indexer and lookback cronjobs #556

Closed paripooranan20 closed 5 months ago

paripooranan20 commented 5 months ago

What happened?

While adding imagePullSecrets in the values, the esLookback and esIndexCleaner cronjobs give a helm render error

Steps to reproduce

  1. Add an imagePullSecret under image in either of esLookback or esIndexCleaner values section
  2. Set enabled as true (For the selected section)
  3. Render the manifests using helm template . -f values.yaml

Expected behavior

The imagePullSecrets should be added under the cronjob, instead it gives a YAML conversion error

Relevant log output

`Error: YAML parse error on jaeger/templates/es-index-cleaner-cronjob.yaml: error converting YAML to JSON: yaml: line 29: mapping values are not allowed in this context`

Screenshot

No response

Additional context

This can be fixed by changing the indent from 12 to 10 in line 41 of both es-lookback-cronjob.yaml and es-index-cleaner-cronjob.yaml

(Refer es-rollover-cronjob.yaml for correct implementation)

Jaeger backend version

v1.53

Deployment configs

esIndexCleaner:
  enabled: true
  image:
    registry: ""
    repository: jaegertracing/jaeger-es-index-cleaner
    pullPolicy: IfNotPresent
    pullSecrets:
    - name: xyz-io-secret