[jaeger] correct indentation of imagePullSecrets in indexer and lookback cronjobs - Githubissues

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

269 stars 347 forks source link

[jaeger] correct indentation of imagePullSecrets in indexer and lookback cronjobs #568

Closed coryflucas closed 6 months ago

coryflucas commented 6 months ago

What this PR does

Correct indentation of imagePullSecrets in indexer and lookback cronjobs. This can be confirmed by running:

helm template . --set "global.imagePullSecrets.0=test" --set esIndexCleaner.enabled=true
helm template . --set "global.imagePullSecrets.0=test" --set esLookback.enabled=true

Both of these would previously fail with errors like

Error: YAML parse error on jaeger/templates/es-index-cleaner-cronjob.yaml: error converting YAML to JSON: yaml: line 29: mapping values are not allowed in this context

Which issue this PR fixes

fixes #556

Checklist

[x] DCO signed
[x] Commits are GPG signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[x] README.md has been updated to match version/contain new values