jaegertracing / helm-charts

Helm Charts for Jaeger backend
Apache License 2.0
254 stars 338 forks source link

[Bug]: Using ingress host starting with wildcard causes YAML parse error #571

Closed coryflucas closed 2 months ago

coryflucas commented 2 months ago

What happened?

As a Jaeger operator I want to use a host starting with a wildcard (*) for one of the ingress resources but I receive a YAML parse error.

Steps to reproduce

  1. From the root of the jaeger chart folder run helm template . --set "query.ingress.enabled=true" --set "query.ingress.hosts[0]=*.example.test"
  2. Receive error:
    Error: YAML parse error on jaeger/templates/query-ing.yaml: error converting YAML to JSON: yaml: line 14: did not find expected alphabetic or numeric character

Expected behavior

Template rendered successfully with wildcard host

Relevant log output

Error: YAML parse error on jaeger/templates/query-ing.yaml: error converting YAML to JSON: yaml: line 14: did not find expected alphabetic or numeric character
helm.go:84: [debug] error converting YAML to JSON: yaml: line 14: did not find expected alphabetic or numeric character
YAML parse error on jaeger/templates/query-ing.yaml
helm.sh/helm/v3/pkg/releaseutil.(*manifestFile).sort
        helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:146
helm.sh/helm/v3/pkg/releaseutil.SortManifests
        helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:106
helm.sh/helm/v3/pkg/action.(*Configuration).renderResources
        helm.sh/helm/v3/pkg/action/action.go:165
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
        helm.sh/helm/v3/pkg/action/install.go:259
main.runInstall
        helm.sh/helm/v3/cmd/helm/install.go:264
main.newTemplateCmd.func2
        helm.sh/helm/v3/cmd/helm/template.go:82
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/cobra@v1.3.0/command.go:856
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/cobra@v1.3.0/command.go:974
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/cobra@v1.3.0/command.go:902
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
        runtime/proc.go:255
runtime.goexit
        runtime/asm_amd64.s:1581

Jaeger backend version

v1.53.0

Deployment model

Helm chart

Deployment configs

values.yaml:

query:
  ingress:
    enabled: true
    hosts:
      - "*.example.test"