[jaeger] add new options, improvements into allInOne

jaegertracing / helm-charts

Helm Charts for Jaeger backend

Apache License 2.0

254 stars 338 forks source link

[jaeger] add new options, improvements into allInOne #586

Closed rgaduput closed 1 week ago

rgaduput commented 1 week ago

What this PR does

[jaeger] allInOne add option automountServiceAccountToken for serviceaccount
[jaeger] allInOne add affinity support
[jaeger] allInOne add topologySpreadConstraints support
[jaeger] allInOne add podSecurityContext and containerSecurityContext support

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Checklist

[x] DCO signed
[x] Commits are GPG signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
[x] README.md has been updated to match version/contain new values

pavelnikolov commented 1 week ago

@rgaduput make sure your commits are signed otherwise I cannot merge your PR.

Merging is blocked The base branch requires all commits to be signed

rgaduput commented 1 week ago

@rgaduput make sure your commits are signed otherwise I cannot merge your PR.

Merging is blocked The base branch requires all commits to be signed

@pavelnikolov yes all 4 commits are signed. Below is how they are, hoping this is what expected otherwise please let me know

pavelnikolov commented 1 week ago

https://docs.github.com/authentication/managing-commit-signature-verification/about-commit-signature-verification

You need to GPG sign the commits, not just provide your name and email.

rgaduput commented 1 week ago

The base branch requires all commits to be signed. Learn more about signing commits. You need to GPG sign the commits, not just provide your name and email.

ok, let me see how to do that.

rgaduput commented 1 week ago

The base branch requires all commits to be signed. Learn more about signing commits. You need to GPG sign the commits, not just provide your name and email.

ok, let me see how to do that.

@pavelnikolov Done all commits GPG signed now. Could you please check and merge

rgaduput commented 1 week ago

@pavelnikolov thanks, Could you please take a look at the deployments due to some issue chart was not released https://github.com/jaegertracing/helm-charts/deployments/github-pages

pavelnikolov commented 1 week ago

re-running fixed it, thanks